Merged
Conversation
hero78119
force-pushed
the
feat/mem_docs
branch
from
9398e55 to
06a3543
Compare
kunxian-xia
reviewed
Apr 23, 2026
| @@ -0,0 +1,87 @@ | |||
| # Memory Continuation Checks | |||
Collaborator
There was a problem hiding this comment.
@copilot does this doc implies the main intuition/idea that heap/init does not need to initialized in the first shard? We can load it until it's first accessed. Then we have to require that not a single address are being initialized twice.
Contributor
There was a problem hiding this comment.
Yes—that is the intended model. I updated the doc to state lazy dynamic init explicitly: early shards can have zero-length heap/hint segments until first access, and continuation is append-only/non-overlapping so an address cannot be initialized twice across shards. Fixed in fc8fc48.
Agent-Logs-Url: https://github.com/scroll-tech/ceno/sessions/301be933-f753-4a8d-a421-7f92a024053d Co-authored-by: kunxian-xia <1082586+kunxian-xia@users.noreply.github.com>
auto-merge was automatically disabled
April 23, 2026 03:32
Head branch was pushed to by a user without write access
kunxian-xia
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docs follows #1223
Copilot Reviewer Directive (keep this section)
When Copilot reviews this PR, apply
.github/copilot-instructions.mdstrictly.